Closed
Bug 1868306
Opened 1 years ago
Closed 4 months ago
Fix a clippy warning in intl/l10n/rust/l10nregistry-rs/src/solver/mod.rs
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox136 fixed)
RESOLVED
FIXED
136 Branch
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: asthetiklee, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=rust])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
intl/l10n/rust/l10nregistry-rs/src/solver/mod.rs
44:9 warning manual implementation of `Iterator::find` clippy::manual_find (clippy)
Links to the code:
https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/intl/l10n/rust/l10nregistry-rs/src/solver/mod.rs#44
To run clippy:
./mach lint -l clippy intl/l10n/rust/l10nregistry-rs/src/ -W -v -n
As the change is trivial, it is just to learn how to contribute to Firefox.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Simplified the closure in the position method by using dereferencing instead of pattern matching.
|
||
Updated•5 months ago
|
Assignee: nobody → asthetiklee
Status: NEW → ASSIGNED
Pushed by earo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14405a2bb13e
Refactor has_missing_cell method for improved readability. r=eemeli
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•